Refs #32685 - Keep modulized model name in Global ID

[kamils-iRonin]

This is to properly handle model names that are scoped by plugin name. Because the graphql type name can't contain :: we could use _ instead

 module ForemanPuppet
   module Types
     class Environment < ::Types::BaseObject
       graphql_name 'ForemanPuppet_Environment'

however, the Global ID should contain the correct model name, with ::.

[1] pry(main)> Foreman::GlobalId.decode("MDE6Rm9yZW1hblB1cHBldDo6RW52aXJvbm1lbnQtMjgz")
=> [1, "ForemanPuppet::Environment", "283"]

[theforeman-bot]

Issues: #32685

[evgeni]

Is that the same/related to the patch @ofedoren has in #9449?

[kamils-iRonin]

Is that the same/related to the patch @ofedoren has in #9449?

This is a slightly different as it addresses the proper generation of Global ID for models scoped by plugin name. I would merge #9449 first, then rebase and merge this one.

[evgeni]

I've merged #9449, go ahead with the rebase :)

[kamils-iRonin]

rebased and all 🟢

[evgeni]

This looks correct to me, but my GraphQL knowledge is really limited.

@ofedoren mind having a second look here?

[ofedoren]

Well, I've done something similar, but kidna hidden: 6b557cf

Instead of explicitly call graphql_name for each resource/plugin, my changes would try to do it automatically unless we can directly assign the actual model via graphql_type.

This PR just makes the same, but explicitly. I'm not against this fix, just not sure if it's actually needed.

UPD: I can also be mistaken since my understanding of the library is also poor...

[kamils-iRonin]

This PR just makes the same, but explicitly.

I don't think it's the same. I just tested Global Id generation on the develop branch and used the puppet plugin for testing.

[1] pry(main)> Foreman::GlobalId.decode(Foreman::GlobalId.for(ForemanPuppet::Environment.find(5)))
=> [1, "Environment", "5"]

As you can see, ForemanPuppet namespace is missing in the type name. So, I set graphql_name to ForemanPuppet_Environment (theforeman/foreman_puppet#311) and tested again.

[1] pry(main)> Foreman::GlobalId.decode(Foreman::GlobalId.for(ForemanPuppet::Environment.find(5)))
=> [1, "ForemanPuppet_Environment", "5"]

It's better, but still, I expected the type to be ForemanPuppet::Environment, as it is in Foreman 3.4, before the GraphQL update. And this patch fixes that.

[1] pry(main)> Foreman::GlobalId.decode(Foreman::GlobalId.for(ForemanPuppet::Environment.find(5)))
=> [1, "ForemanPuppet::Environment", "5"]

[ekohl]

@ofedoren is on PTO, but I'm going to trust your code changes.