This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
Fixes #12994 - Rails 4 compatibility #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dLobatog shouldn't the required foreman version change with these changes? it's still |
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| templates.each do |template| | |||
| template[:template] = File.read(File.join(ForemanChef::Engine.root, "app/views/foreman/unattended", template.delete(:source))) | |||
| ProvisioningTemplate.find_or_create_by_name(template).update_attributes(defaults.merge(template)) | |||
| ProvisioningTemplate.where(:name => template).first_or_create.update_attributes(defaults.merge(template)) | |||
There was a problem hiding this comment.
this doesn't work for me:
PG::Error: ERROR: missing FROM-clause entry for table "name" LINE 1: ...templates"."type" IN ('ProvisioningTemplate') AND "name"."na...
using template[:name] instead of template fixed it.
|
@dLobatog any chance, you'll get to Ori's comments? |
ares
added a commit
that referenced
this pull request
Jan 25, 2016
Fixes #12994 - Rails 4 compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed lib/tasks, /config and /test as they were completely unused.