Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #34 - Create github workflow for testing #36

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Fix #34 - Create github workflow for testing #36

merged 1 commit into from
Dec 21, 2022

Conversation

maccelf
Copy link
Member

@maccelf maccelf commented Dec 21, 2022

No description provided.

@maccelf maccelf force-pushed the add_github_workflow branch 25 times, most recently from d8492dc to 8fac3d2 Compare December 21, 2022 14:03
@maccelf
Copy link
Member Author

maccelf commented Dec 21, 2022

Now we have a problems with rubocop action:
https://github.com/maccelf/foreman_kernel_care/actions/runs/3749955289/jobs/6369052096
https://github.com/ATIX-AG/foreman_scc_manager/actions/runs/3739593051/jobs/6348508054
We should fix this problem with qpid-proton and after that i will add rubocop action

@maccelf maccelf mentioned this pull request Dec 21, 2022
Closed
@maccelf maccelf merged commit 296dbe5 into master Dec 21, 2022
@maccelf maccelf mentioned this pull request Dec 21, 2022
Merged
@sbernhard
Copy link
Collaborator

Would be good to use rubocop to chech code style.
See e.g. https://github.com/theforeman/foreman_salt/blob/master/.github/workflows/rubocop.yml

@maccelf maccelf mentioned this pull request Dec 23, 2022
Merged
@maccelf maccelf deleted the add_github_workflow branch September 28, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maccelf @sbernhard