Fixes #29728 - fix epel check if any misconfigured repo present #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #29728 |
upadhyeammit
suggested changes
May 21, 2020
| @@ -16,7 +16,8 @@ def run | |||
| end | |||
|
|
|||
| def epel_enabled? | |||
| system_repos = execute("yum repolist enabled -d 6 -e 0| grep -E 'Repo-baseurl|Repo-id'") | |||
| cmd = "grep -ir --no-filename --include=\*.repo -E 'baseurl|metalink' /etc/yum.repos.d/" | |||
There was a problem hiding this comment.
If you use this grep command we end up showing epel enabled even if repository is disabled, because we are not checking for enabled flag ?
Another challenge is, one .repo file can have multiple repos, so in that case I think you end up searching the enabled flag ?
There was a problem hiding this comment.
@upadhyeammit yeah, My bad. :P
You are right. I forgot to check "is enabled" part.
I will re-think and will submit the PR again.
There was a problem hiding this comment.
@patilsuraj767 any new thoughts on this ?
|
As this pull request is stale to current state of the repository I am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.