Fixes #33245 - use correct repo names on EL8 #561
Conversation
|
Issues: #33245 |
|
this freaks out the 👮, but we can discuss the layout before I try to defund them? |
|
@upadhyeammit per our conversations, here is another good example of being able to define and store the repositories in a single place to reduce chance to typo them or get it wrong, both within here and #546 we are defining repo names |
Ack, I will have a separate pr for that: https://projects.theforeman.org/issues/33995 |
|
Updated, now with passing 👮 and simple tests. Beta names still borked. |
evgeni
force-pushed
the
issue33245
branch
3 times, most recently
from
7399ded
to
7821817
Compare
| elsif el7? | ||
| ["rhel-#{el_major_version}-server-#{package_name}-#{full_version}-rpms"] | ||
| elsif use_beta_repos? | ||
| ["#{package_name}-#{maj_version}-beta-for-rhel-#{el_major_version}-x86_64-rpms"] |
There was a problem hiding this comment.
this follows the style of satellite-tools-6-beta-for-rhel-8-x86_64-rpms which we already have today.
| elsif el7? | ||
| ["rhel-#{el_major_version}-server-satellite-maintenance-#{sat_maint_version}-rpms"] | ||
| elsif use_beta_repos? | ||
| ["satellite-maintenance-#{sat_maint_version}-beta-for-rhel-#{el_major_version}-x86_64-rpms"] |
There was a problem hiding this comment.
will it be satellite-maintenance-7-beta-for-rhel-8-x86_64-rpms or satellite-maintenance-7.0-beta-for-rhel-8-x86_64-rpms? I would guess the former?
There was a problem hiding this comment.
I think the latter since the repository for maintenance is now versioned per Satellite version
There was a problem hiding this comment.
sure, but also for satellite itself, the beta repo was always "6-beta", whichever beta we shipped in there (I don't mind either way, just pointing out history)
There was a problem hiding this comment.
Ohh you are saying it was a one size fits all beta repository. That is indeed a question I do not know the answer to.
There was a problem hiding this comment.
I've updated it now to use -7-beta- to match the other names, but can adjust later, of course.
No description provided.