Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #33620 - unify maintenance repo var and param name #604

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Refs #33620 - unify maintenance repo var and param name #604

merged 1 commit into from
Apr 5, 2022

Conversation

upadhyeammit
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #33620

@upadhyeammit
Copy link
Contributor Author

@Gauravtalreja1 check the var names, I tried my best to keep those sensible.
@ehelms few changes to make var and param same, I was about to add it in previous pr however we merged it.

@upadhyeammit upadhyeammit mentioned this pull request Apr 4, 2022
Merged
Gauravtalreja1
Gauravtalreja1 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upadhyeammit Looks good to me

@upadhyeammit upadhyeammit merged commit e228d6b into theforeman:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upadhyeammit @theforeman-bot @ehelms @Gauravtalreja1