Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename capsule to proxy #338

Merged
merged 2 commits into from
Dec 16, 2016
Merged

Rename capsule to proxy #338

merged 2 commits into from
Dec 16, 2016

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Dec 7, 2016

No description provided.

@stbenjam stbenjam changed the title [WIP] Rename capsule to proxy Rename capsule to proxy Dec 9, 2016
capsule)
katello_capsule=true
proxy)
katello_proxy=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick -- should we stick to proxy_content for consistency across all the re-names?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case should just be proxy, in line with the filename. On the other hand I'd also like to kill this file (like #334 helps to do)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stbenjam thoughts on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought we could keep it katello_proxy for now, it's going to go anyway with #334.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@@ -0,0 +1,29 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would an install not be able to use the katello_repositories role to achieve this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a straight rename, it's there now for the capsule module.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not get into the business of trying to refactor things alongside the rename, we could fix this after.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Touche -- I didn't put two and two together (equals 5 right?)

Copy link
Member Author

@stbenjam stbenjam Dec 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, for large values of 2. It's worth fixing though, #340

@stbenjam stbenjam merged commit dd103a3 into theforeman:master Dec 16, 2016
@stbenjam stbenjam deleted the capsule branch December 16, 2016 16:04
daviddavis pushed a commit to daviddavis/forklift that referenced this pull request Feb 21, 2017
johnpmitsch pushed a commit to johnpmitsch/forklift that referenced this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants