Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #13966 - newer version of apipie validates types for arrays #221

Merged

Conversation

tstrachota
Copy link
Member

Therefore we no longer can send network interfaces in hashes even though
the server would cope with it.

The PR also fixes api mocking and expectations that used to skip param validations.

@domcleal domcleal changed the title fixes 13966 - newer version of apipie validates types for arrays fixes #13966 - newer version of apipie validates types for arrays Mar 4, 2016
@domcleal
Copy link
Contributor

domcleal commented Mar 4, 2016

Note the commit message is missing a # before the ticket number.

@tstrachota tstrachota force-pushed the host_interfaces_format_13966 branch from cc1cc66 to 78832c1 Compare March 4, 2016 09:55
@tstrachota
Copy link
Member Author

Oops, good catch @domcleal Fixed

@tstrachota tstrachota force-pushed the host_interfaces_format_13966 branch from 78832c1 to 3649441 Compare March 4, 2016 12:15
@tstrachota
Copy link
Member Author

The related apipie-bindings PR has been merged, waiting for a new release now.

@tstrachota tstrachota force-pushed the host_interfaces_format_13966 branch from 3649441 to 7db62ba Compare March 9, 2016 14:28
Therefore we no longer can send network interfaces in hashes even though
the server would cope with it.
@iNecas
Copy link
Member

iNecas commented Mar 11, 2016

Tested and works well, also no code comments. Clean 👍. Thanks @tstrachota !

tstrachota pushed a commit that referenced this pull request Mar 14, 2016
fixes #13966 - newer version of apipie validates types for arrays
@tstrachota tstrachota merged commit a5d864a into theforeman:master Mar 14, 2016
@tstrachota tstrachota deleted the host_interfaces_format_13966 branch May 17, 2017 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants