Fixes #4573 -Better error message for unknown template kind #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabajaj0509
force-pushed
the
4573-error-message
branch
4 times, most recently
from
c77109a
to
242ef6a
Compare
tstrachota
reviewed
Oct 16, 2017
test/functional/template_test.rb
Outdated
|
|
||
| describe 'create' do | ||
| before do | ||
| @cmd = %(template create) |
There was a problem hiding this comment.
@rahulbajaj0509 your @cmd is string, which makes the tests fail on "no implicit conversion of Array into String (TypeError)".
It should have been @cmd = %w(template create)
rabajaj0509
force-pushed
the
4573-error-message
branch
2 times, most recently
from
6ebd962
to
94583d2
Compare
rabajaj0509
force-pushed
the
4573-error-message
branch
from
94583d2
to
5307b53
Compare
|
@tstrachota sorry for the delay. Fixed the tests, all green :) |
|
👍 @rahulbajaj0509, thanks. Looks good now and fixes the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.