Refs #8810 - send params of type number as numbers #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR actually doesn't solve the issue mentioned in the commit message. I'm describing details in http://projects.theforeman.org/issues/8810#note-12 This fix is still valuable though. I propose to get this merged with different issue http://projects.theforeman.org/issues/11084 |
|
@mbacovsky looks good, pending the issue change. There are some test issues in the related PR into hammer-cli-foreman theforeman/hammer-cli-foreman#184 |
|
As this PR is mutually conflicting with #173 and is touching very similar problem I added it as a second commit there. By mistake I created another issue and referenced the fixes to that. I closed the issue you created as duplicate, sorry. 🐮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.