Do not use global environmentpath

[mattock]

This prevents the Kafo installer from crashing if the default (global)
environment, typically /etc/puppetlabs/code/environments/production, includes a
classes array that contains classes not provided by the installer. This is often
the case when running the Kafo installer on a production Puppetmaster where
environments have been deployed.

[theforeman-bot]

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

[mattock]

This issue has been discussed in more detail on Foreman Support forum. The resulting puppet.conf file looks like this:

[main]
color = false
environmentpath = /tmp/kafo_hiera20180911-30532-ekc6gy
evaltrace = true
hiera_config = /tmp/kafo_hiera20180911-30532-ekc6gy/hiera.conf
noop = false
profile = false
reports =
show_diff = true

This change has only been tested on Puppet 5.5.6. However, the environmentpath parameter seems to have been available as early as Puppet 3.x.

[ares]

Thanks for the patch, @ekohl do you think this is going to work with foreman-installer in case hiera overrides are used?

[ekohl]

I'm a bit unfamiliar with this part of kafo but I don't know if we really have environments. I'm wondering if it's good to set environmentpath to empty and only set the modulepath.

[ekohl]

This is still on my radar, but haven't had time to verify it yet. It does look like we should also set basemodulepath to something we control to avoid things leaking into our environment.

[ekohl]

Apologies it took me so long to get to, but I've confirmed this works with Puppet 6.3.0.