Option Static routes support - RFC 3442

[davidblaisonneau-orange]

This PR add an option to add static routes with DHCP.
See:

• https://tools.ietf.org/html/rfc3442
• https://ercpe.de/blog/pushing-static-routes-with-isc-dhcp-server

[ekohl]

I think you also need a check if it's non-empty.

[ekohl]

Would you mind adding a test case as well? And the tests need to pass. Otherwise I think it's a good addition.

[davidblaisonneau-orange]

Travis seems to be happy :) I hope the tests are ok for you.

[ekohl]

👍
@domcleal / @mmoll?

[mmoll]

I don't use the -dhcp module, so I can't say too much content-wise, but the tests look OK, so 👍

@davidblaisonneau-orange could you squash your commits together into one?

[mmoll]

@davidblaisonneau-orange there are still 8 commits. git rebase -i HEAD~8 and the usual squash/fixup dance should do the trick, followed by a force push into the master branch of your fork.

[ekohl]

BTW, I don't mind squashing it and pushing the squashed commit if you can't figure it out.

[davidblaisonneau-orange]

This should be better. Sorry for the delay, PR is something quite new for me

[ekohl]

@davidblaisonneau-orange no problem, we've all been there. The only thing that would finish it if you could fix the commit message to something more meaningful.

[davidblaisonneau-orange]

Now it should be fine :)

[ekohl]

👍

[mmoll]

could you please use

<% if @static_routes -%>
<%   @static_routes.each do |static_route| -%>
...
<%   end -%>
<% end -%>

or similar here? I was just confused by seeing two <% end -%>s and thought of a duplicate line.

[mmoll]

👍 after fixing the minor whitespace nit.

[davidblaisonneau-orange]

Done

[mmoll]

👍

[ekohl]

Thanks!

[davidblaisonneau-orange]

Thanks to you !