Fixes #6751 - convert interface name to fact expected value #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we'll probably need similar fix for proxydns, is this a good way to go? |
|
👍 I think this is the way to go. |
|
Ok, I fixed it for dns as well. Feel free to merge :-) |
|
Please fix the tests on 1.8.7. |
|
Fixed |
ehelms
pushed a commit
to ehelms/puppet-foreman_proxy
that referenced
this pull request
Aug 25, 2017
Gzip the db dump for easier remote backup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.