Fixes #36438 - configure API request limit to avoid memory leaks #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
May 25, 2023
ekohl
approved these changes
May 25, 2023
dralley
reviewed
Jul 19, 2023
| @@ -233,6 +239,8 @@ | |||
| Integer[0] $api_service_worker_count = min(4, $facts['processors']['count']) + 1, | |||
| Integer[0] $content_service_worker_timeout = 90, | |||
| Integer[0] $api_service_worker_timeout = 90, | |||
| Integer[0] $api_service_worker_max_requests = 50, | |||
There was a problem hiding this comment.
@evgeni We discovered the "real" root cause now, so we can relax this number significantly. I would back it off to a much higher value, like say 1000 for the limit and 200 for the jitter.
There was a problem hiding this comment.
Do you have a link to info about the real root cause?
There was a problem hiding this comment.
See the discussion near the end on the BZ https://bugzilla.redhat.com/show_bug.cgi?id=2122872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.