Auth crl allow #139
Merged
Auth crl allow #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -298,8 +303,8 @@ | |||
| validate_string($ca_server) | |||
| validate_string($server_external_nodes) | |||
|
|
|||
| class { 'puppet::config': } -> | |||
| Class['puppet'] | |||
| include ::puppet::config | |||
There was a problem hiding this comment.
Why change this to an include? a standard class definition works the same way...
There was a problem hiding this comment.
True, but this is leftover from a test to see if I could use puppet::config params in the tests instead of puppet. That didn't work. It is now consistent with agent and server a few lines below so I didn't bother changing it back.
There was a problem hiding this comment.
Fair point. Not opposed to it, just curious.
|
Untested but seems like it should work :) |
| @@ -199,6 +199,9 @@ | |||
| # Valid values are 'v2' for latest, and 'v1' | |||
| # for Foreman =< 1.2 | |||
| # | |||
| # $allow_any_crl:: Allow any authentication for the CRL. This | |||
| # is needed for the puppet CA proxy. | |||
There was a problem hiding this comment.
Missing type:boolean for kafo
http://docs.puppetlabs.com/guides/scaling_multiple_masters.html#option-2-proxy-certificate-traffic states the following should be present in auth.conf if using a puppet ca proxy: path /certificate_revocation_list auth any method find allow * In my testing /certificate_revocation_list/ca was sufficient.
|
Updated & rebased. |
|
Merged, thanks @ekohl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch first refactors puppet::config a bit to make it easier to extend. It also adds fairly minimal tests. The next patch adds an auth_crl_allow parameter. http://docs.puppetlabs.com/guides/scaling_multiple_masters.html#option-2-proxy-certificate-traffic states the following should be present in auth.conf if using a puppet ca proxy:
path /certificate_revocation_list
auth any
method find
allow *
In my testing /certificate_revocation_list/ca was sufficient.