Fixes #35728 - Disable telemetry by default #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbclark
reviewed
Nov 7, 2022
There was a problem hiding this comment.
This could be Optional[Boolean] $server_puppetserver_telemetry = undef, and then interpret
false - intentional opt out
true - intentional opt in
undef - opt in (puppet default)
installer answers would set it to false and installer would get a migration that sets it to false if previously undef, which makes false the installer default without clobbering intentional opt ins
that should cover all bases except 1. installer users who already used release 16.3.0 of this module, 2. and non-installer users, and we'd need release notes for those users.
|
That may actually be better yes. At least for the future to explicitly record the opt-in/opt-out. |
ekohl
force-pushed
the
disable-telemetry-by-default
branch
2 times, most recently
from
7c380b8
to
58fd7a8
Compare
Puppetserver 7.0 adopted opt-out telemetry[1], meaning telemetry is sent by default. Foreman traditionally has had a policy where no telemetry was sent by default. Disabling the telemetry would bring align Puppetserver to this policy. It uses Optional[Boolean] so the Foreman installer can explicitly record the users answer if they choose anything, where undef means whatever the module thinks is best. [1]: https://puppet.com/docs/puppet/7/server/puppet_server_usage_telemetry.html
ekohl
force-pushed
the
disable-telemetry-by-default
branch
from
58fd7a8
to
95788e3
Compare
evgeni
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppetserver 7.0 adopted opt-out telemetry, meaning telemetry is sent by default. Foreman traditionally has had a policy where no telemetry was sent by default. Disabling the telemetry would bring align Puppetserver to this policy.
Still a draft since I haven't checked all the implications. Users of the installer will also need to change their answer. Possibly this could be a migration, but then we'd disrespect users who wanted to opt-in. Possibly an upgrade note.