Move to Ruby 2.7+ #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd say yes. |
ekohl
force-pushed
the
drop-ruby-pre-2.7
branch
from
1c5f540
to
ca2f188
Compare
|
The diffs would be smaller if #43 was merged, but I've updated it now. |
ekohl
force-pushed
the
drop-ruby-pre-2.7
branch
from
ca2f188
to
c60facc
Compare
Since ruby_parser 2.0.0 it stopped using StringIO and now uses StringScanner. That means the patch hasn't applied since 2008. Fixes: eb79570
ekohl
force-pushed
the
drop-ruby-pre-2.7
branch
from
c60facc
to
ebbe992
Compare
|
Could we also drop |
Fixes: eb79570 ("Initial commit")
Ruby 2.5 and 2.6 are unsupported and providing Ruby 3 compatibility is easier with Ruby 2.7 as the lower bound.
Ruby 3 has changed keyword argument handling and safemode doesn't deal with that correctly. That means it's broken in various cases.
ekohl
force-pushed
the
drop-ruby-pre-2.7
branch
from
ebbe992
to
76c35e8
Compare
|
Done |
|
Thank you @ekohl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.5 and 2.6 are unsupported and providing Ruby 3 compatibility is easier with Ruby 2.7 as the lower bound.
It should be noted that from testing it appears Ruby 3 support is broken. Should the upper bound be lower to
< 3for now?