Fixes #21164 - add missing ensure blocks

[lzap]

I have no proofs this fixes any memory leaks at all, but it is a good practice to add those ensure blocks. I have a suspicion that it might help my customer to mitigate memory leaks in Satellite 6.2 branch.

[xprazak2]

👍 APJ

[lzap]

Getting SEGFAULT downstream:

/home/jenkins/.rvm/gems/ruby-2.0.0-p648@satellite6-unit-test-smart-proxy-openscap-0/gems/openscap-0.4.7/lib/openscap/xccdf/benchmark.rb:49: [BUG] Segmentation fault
ruby 2.0.0p648 (2015-12-16 revision 53162) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0077 p:---- s:0354 e:000353 CFUNC  :xccdf_benchmark_get_profiles
c:0076 p:0022 s:0350 e:000349 METHOD /home/jenkins/.rvm/gems/ruby-2.0.0-p648@satellite6-unit-test-smart-proxy-openscap-0/gems/openscap-0.4.7/lib/openscap/xccdf/benc
c:0075 p:0021 s:0343 e:000342 METHOD /home/jenkins/.rvm/gems/ruby-2.0.0-p648@satellite6-unit-test-smart-proxy-openscap-0/gems/openscap-0.4.7/lib/openscap/xccdf/benc
c:0074 p:0021 s:0340 e:000339 METHOD /home/jenkins/workspace/satellite6-unit-test-smart-proxy-openscap/nodes/rhel/ruby/2.0.0/lib/smart_proxy_openscap/openscap_conte
c:0073 p:0017 s:0335 e:000334 LAMBDA /home/jenkins/workspace/satellite6-unit-test-smart-proxy-openscap/nodes/rhel/ruby/2.0.0/lib/smart_proxy_openscap/openscap_api.r [FINISH]
c:0072 p:---- s:0331 e:000330 CFUNC  :call
c:0071 p:0012 s:0328 e:000327 BLOCK  /home/jenkins/.rvm/gems/ruby-2.0.0-p648@satellite6-unit-test-smart-proxy-openscap-0/gems/sinatra-1.4.8/lib/sinatra/base.rb:1611 [FINISH]

[lzap]

Okay solved downstream, I freed one extra object, this is correct in this PR.

[lzap]

Guys, we have reports from downstream that this small patch did help. Although this has been extracted into separate process, it is good idea to close resources correctly.

[ares]

Our jenkins seems to use openscap >= 1.2.11, < 1.2.15 which contains the bug that prevents this from working. I ran tests manually and got

33 tests, 73 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

since we got ack from @xprazak2 (thanks), I'm merging it. Thanks @lzap!