Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format logging output for increased legibility #609

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

geealbers
Copy link
Member

Adds [quire] prefix, log types, and column spacing. See https://jira.getty.edu/browse/DEV-13749.

@geealbers geealbers requested a review from a team November 30, 2022 21:41
Co-authored-by: matthew p hrudka <mphstudios@users.noreply.github.com>
@geealbers
Copy link
Member Author

@mphstudios You asked about what this looks like when the line breaks and you're right it is wonky:

Screen Shot 2022-11-30 at 2 34 03 PM

Though it's pretty wonky even without the columns. Down the road we may want to look at something like https://www.npmjs.com/package/indent-log for better indenting with line breaks:

log3

@mphstudios
Copy link
Member

Down the road we may want to look at something like npmjs.com/package/indent-log for better indenting with line breaks

Absolutely, something like indent-log and/or cliui to better format the output. I also think that we will be able to bring back the fancy colours.

@geealbers @Erin-Cecele @thegetty/int-dev what are your thoughts on including the changes in this pull-request in the pre-release and refactoring later?

@geealbers
Copy link
Member Author

@mphstudios, it makes sense to me to merge this in for the pre-release as is, and then refactor it later

@Erin-Cecele
Copy link
Collaborator

@mphstudios @geealbers @thegetty/int-dev Despite it being hard to read with the line breaks, I think overall, the messaging is clearer and more helpful. I'd love to see this merged for the pre-release and refactored later.

@mphstudios mphstudios merged commit b1f98e8 into feature/11ty Dec 1, 2022
@mphstudios mphstudios deleted the feature/DEV-13749_log-formatting branch December 1, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants