DEV-13813: Only write SVG symbol definitions to PDF output once #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geealbers good catch, writing these SVGs for each section was an oversight, this should fix it
Thank you for contributing to Quire! Please complete the form below to submit your pull request for review.
For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Fix, Feature, Docs, or Chore. Issue-# is only needed if this pull request addresses an exisiting issue.
Checklist
Please put an
Xwithin the brackets that apply[X].I have read the CONTRIBUTING.md file
I have made my changes in a new branch and not directly in the main branch
This pull request is ready for final review by the Quire team
Is this pull request related to an open issue? If so, what is the issue number?
DEV-13813
Please briefly describe the goal of this pull request and how it may impact Quire's functionality.
We were including SVG symbol definitions to display CC license icons in PDF output, but they were being included before each
<section>elementPlease describe the changes you made, and call out any details you think are particularly relevant for the Quire team to note in their review.
Only write SVG symbol definitions for the first collection index
Does this pull request necessitate changes to Quire's documentation?
Include screenshots of before/after if applicable.
Additional Comments