0.5.18?: Add dark theme + toggle to rambox #26
Comments
|
as much as I NEEED dark themes in all apps, I think that a cosmetic feature should be put in the back burner while other stuff is more important. |
|
I feel this is a need more than a want. Rambox is practically the only thing that doesn't adhere to the macOS dark mode toggle. If Rambox Pro wasn't saas and was just buy a license I'd have probably done it already just for that feature. |
|
I'll look into decoupling the theme from the app build itself (another ExtJS-ism) this weekend, but I can't make promises on it for the time being. |
|
No worries, I just wanted to put this issue back on the map, as it hadn't been mentioned since last year. |
|
Now that rebranding's done, maybe it might be worth revisiting this as other changes are being made? |
|
Adding my vote to this. On the original project, there's a hack posted by Streetturtle here: https://github.com/ramboxapp/community-edition/issues/107#issuecomment-363158680 You can get a dark tab bar by opening the dev console and pasting in some custom JS Can there a more sensible way to automate that than the silly AutoHotKey script I posted further down? :) |
|
Ok, while we wait for an official solution, I've done a hack job that works. You'll need a way to unpack ASAR files. On Windows you can use this 7-zip plugin http://www.tc4shell.com/en/7zip/asar/
The dark theme I'm using is based on https://github.com/ramboxapp/community-edition/issues/107#issuecomment-524582685 but converted to CSS. Note that I don't really know CSS so may have screwed this up, but it seems to work. The services page is a little ugly, but once set up you'll probably never look at that! Perhaps somebody who knows CSS could replace this with a call to an external theme.css file? I don't even know if this is possible! but if it is, could leave a handy hook for theming? |
|
For those who don't fancy doing this by hand, here is my modified app.asar from v0.5.20 This probably won't work for future versions, or if it does it'll downgrade you to 0.5.20 IDK. Use at your own risk etc. |
|
Just wanted to mention I did this same thing in the Mac version
I tweaked the above CSS a bit. Could use a little more work, but it's pretty functional now. As a trickle down the main settings page is also changed, though it could use some TLC too. |
|
@jbwharris - Thanks for improving my terrible attempt at CSS. Here's a terrible attempt at doing the Dracula theme, based on said CSS |
|
I was futzing around with this a bit more and found what could be a really good and painless solution to implementing dark mode without actually having to change anything in the app. There is a media query called
|
|
I took another crack at refining this dark mode CSS. I'd messed up the settings page one of my lines previously, so now it's all styled. I included screenshots of being able able to switch my OS settings from light to dark and Hamsket adhering to the settings. I'm sure it could use some more work for some of the smaller detail things and general CSS optimization, but I think it's a really good start.
|
|
This would be super-welcome feature for me as well |
Would require some work, but seems feasible to do for 0.5.18.
If other stuff is important enough to delay this a release cycle or two, let me know!
The text was updated successfully, but these errors were encountered: