Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate SUNAT cdr response #148

Merged
merged 47 commits into from
Oct 12, 2020
Merged

Conversation

giansalex
Copy link
Member

No description provided.

@giansalex giansalex linked an issue Oct 12, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #148 into master will increase coverage by 2.64%.
The diff coverage is 96.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #148      +/-   ##
============================================
+ Coverage     95.31%   97.96%   +2.64%     
- Complexity     1893     1897       +4     
============================================
  Files           153      153              
  Lines          4570     4612      +42     
============================================
+ Hits           4356     4518     +162     
+ Misses          214       94     -120     
Flag Coverage Δ Complexity Δ
#unittests 97.96% <96.63%> (+2.64%) 1897.00 <61.00> (+4.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ator/src/Validator/Loader/DespatchDetailLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../validator/src/Validator/Loader/ExchangeLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...s/validator/src/Validator/Loader/InvoiceLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ages/validator/src/Validator/Loader/NoteLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...or/src/Validator/Loader/PerceptionDetailLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...tor/src/Validator/Loader/RetentionDetailLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...s/validator/src/Validator/Loader/SummaryLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...lidator/src/Validator/Loader/v21/InvoiceLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../validator/src/Validator/Loader/v21/NoteLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ator/src/Validator/Loader/v21/SaleDetailLoader.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1f8970...143de93. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@giansalex giansalex merged commit e0caf10 into master Oct 12, 2020
@giansalex giansalex deleted the bugfix/validate-sunat-response branch October 12, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOMDocument::loadXML(): Empty string supplied as input
1 participant