This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
languages: drop '@theia/languages' #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit removes the `@theia/languages` extension dependency since it is deprecated in favor of using vscode extensions to provide language-support. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
1 task
|
I think we'll need to merge #393 before the |
marcdumais-work
approved these changes
Aug 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #387
The following pull-request removes the deprecated
@theia/languagesextension from both images and apps in favor of using vscode extensions to provide language-support.How to test
Verify that CI passes successfully.
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com