[tree] add extra options to the tree search input

[vince-fugnitto]

• added extra showButtons options to the tree search input.
• allows users to navigate their matches more easily using next and previous buttons.
• allows users to close the search input.
• fixed incorrect implementation of the searchBox.onPrevious callback.

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

[lmcbout]

Buttons looks OK and useful
Question 1: when the tree is collapse, the search does not expand the tree to show the result
Question 2: The search is navigating through each tree item when the search does not find anything, should it stay on the current selected tree item when there is no tree item matching the search !
Also, when reaching the last item, it does not loop back , as when an item is found

[vince-fugnitto]

@lmcbout

Question 1: when the tree is collapse, the search does not expand the tree to show the result

That is the current behavior of the tree search and consistent with vscode. Only the visible part of the tree is searchable.

Question 2: The search is navigating through each tree item when the search does not find anything,
should it stay on the current selected tree item when there is no tree item matching the search ?

When there is a match you'll see orange highlighting, if there is no match this highlighting is not present.

Also, when reaching the last item, it does not loop back , as when an item is found.

I am able to see the loop back to the first item.

[vince-fugnitto]

@lmcbout after clarifying with me face-to-face, I'll take a look at why the explorer changes selection when there are no results and next and previous are used.

[vince-fugnitto]

@lmcbout I updated the PR so that only if there are currently highlighted items (matches) do we enable the next and previous buttons. Could you re-test the PR for me?

[lmcbout]

Now, the "Previous" button is searching in the same direction as the "Next" button
For the search with an invalid search option, it works fine.

[vince-fugnitto]

Now, the "Previous" button is searching in the same direction as the "Next" button
For the search with an invalid search option, it works fine.

I fixed the issue, the original implementation was calling the incorrect method for the onPrevious callback. Now we use the selectPrevNode instead of selectNextNode.

[lmcbout]

LGTM
Thanks @vince-fugnitto

[fangnx]

It works nicely! A useful feature ;)