-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: display process tasks in the terminal #5895
Conversation
3306014
to
7a7cb99
Compare
The PR breaks the command Steps to Reproduce:
|
Is there a related issue for it? please reference it with fix in PR body and commit |
`process` tasks aren't displayed in the terminal, whereas it is displayed as such in VS Code. This commit makes it so `process` tasks are displayed the same way `shell` tasks are. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
7a7cb99
to
35ee65d
Compare
@vince-fugnitto should be fixed. |
To people reviewing and that are familiar with VS Code tasks system: Should we rather display any task output in the terminals? Are there cases where the output is not displayed? |
there is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the change in both single and multi root workspace. I verified the followings:
- task can be started and terminated
- attach task worked
- recent tasks are displayed in the quick open properly
- detected tasks are not affected.
Thank you for the work !
@elaihau please make sure to file Theia issues to support these features |
I confirmed that it still works, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes and tried to run tasks:
- with
process
type - with
shell
type npm
tasks
I got output for those tasks, so it works well for me.
Sure Anton. I created #5974 |
I am not sure if Theia needs |
What it does
Displays
process
task output in a terminal like VS Code.Fixes #5908.
How to test
You can use the following task configuration to see that
process
task output is now displayed in a terminal:Review checklist
Reminder for reviewers