Execute tasks via keybindings.

[Wicked7000]

Signed-off-by: Jason Attwood jason_attwood@hotmail.co.uk

What it does

This addresses issue #5870 , allowing for shortcuts to be made to run tasks.

How to test

Create any tasks (or use the default ones that are provided at the bottom here)
Create a keybinding for that task in the following format:

{
        "keybinding": "ctrl+alt+s",
        "command": "workbench.action.tasks.runTask",
        "args": "[Task] Echo a string"
}

the args is the label of the task to execute.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

• please make it a proper PR that others can review and test it as well
• please also get rid of commits which fix issues in the first commit, it should be one commit then

[akosyakov]

@Wicked7000 please squash the git history, commits should be only about new features or fixing code before the PR. Commits which refactor or fix code introduced by the PR should be removed

Please see https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#checklist-commit-history

[akosyakov]

Should it be applied to detected tasks as well or getConfiguredTasks return all tasks, i.e. configured by a user and detected by extensions? cc @theia-ide/task-extension

[Wicked7000]

From what I understand getConfiguredTasks only returns user configured tasks (defined in tasks.json) so if we wanted them to run detected tasks it should be 'getTasks'.

[Wicked7000]

I've changed this to getTasks as that seems like what would be needed but should their be different priority's? As for example what if someone registers a keybind for a label that matches both a detected task and a user configured one, currently it would be whatever is first in the array I think it should be user configured first then detected?

[paul-marechal]

I think it is fine to just use getTasks, since -IIUC- a configured task is a complete override by the user of a given detected task (cc @elaihau?)

[akosyakov]

Code changes are looking good to me. @theia-ide/task-extension please find to verify 🙏

[Wicked7000]

I'll revert the change use getTasks then as it seems getConfiguredTasks is sufficient ?

[RomanNikitenko]

I'll revert the change use getTasks then as it seems getConfiguredTasks is sufficient ?

I think execution of detected tasks without customization won't work if you use getConfiguredTasks() instead of getTasks()

[RomanNikitenko]

I would like to test the changes, please give me about 1 hour for it.
thank you!

[Wicked7000]

Okay that's fine then let me know if you have any issues!

[RomanNikitenko]

I tried to run:

• detected npm task via keybindings
• custom configured task

It works well for me!

I tested the case when we have two tasks with the same label in different tasks.json files (so - different sources).
For example, you have tasks Run tests for different projects.
The current behavior: first found task is run.
I think we could to display both tasks in menu to provide ability to select a task for running.
But looks like the current behavior is the same as VS Code behavior. So up to you.

thank you for giving me time for testing!

[akosyakov]

@RomanNikitenko please merge it tomorrow, if no one objects by that time

[paul-marechal]

@akosyakov should the prompt to select a task when several have the same name be done in a follow up PR?

[akosyakov]

@RomanNikitenko @marechal-p It should behave as in VS Code. Since it is a first-time contribution from @Wicked7000 maybe we accept this PR, do an issue and work on it separately? It also works nice already for standard cases.