Add typescript to builtin html-language-features #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not yet tested |
Fixes #33 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
force-pushed
the
fix-html
branch
from
7a59afd to
0150a7a
Compare
|
I had the chance to test this PR using Gitpod, comparing the behaviour vs master, with an HTML file containing embedded JS code. I think it now works! @akosyakov is on vacation this week, so I think I'll go ahead and merge. I have confirmed that TypeScript and HTML support seem to work fine with the latest vscode baseline (from ~12h ago) so I expect that we'll get one working Unless we take special measures, only new releases (solid and nightly) will be covered by this fix - it would be more complicated to remove from open-vsx.org and re-publish previous versions that are already there. cc: @spoenemann |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Signed-off-by: Marc Dumais marc.dumais@ericsson.com