Fix hidden axes for charts (carbon-design-system#701)

* fix: fix render skeleton for charts * fix: update condition for skeleton Co-authored-by: Fei <fei-fei.zheng@ibm.com>
theiliad · Jul 15, 2020 · ca6270b · ca6270b
1 parent f17fc60
commit ca6270b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/core/src/components/axes/axis.ts b/packages/core/src/components/axes/axis.ts
@@ -438,7 +438,7 @@ export class Axis extends Component {
 
 		// we don't need to show axes on empty state and on skeleton state
 		// because the Skeleton component draws them
-		if (isDataEmpty || isDataLoading) {
+		if (isDataLoading) {
 			container.attr("opacity", 0);
 		}
 

diff --git a/packages/core/src/components/graphs/skeleton.ts b/packages/core/src/components/graphs/skeleton.ts
@@ -23,15 +23,14 @@ export class Skeleton extends Component {
 		});
 		svg.attr("width", width).attr("height", height);
 
-		const isDataEmpty = this.model.isDataEmpty();
 		const isDataLoading = Tools.getProperty(
 			this.model.getOptions(),
 			"data",
 			"loading"
 		);
 
 		// display a skeleton if there is no chart data or the loading flag is set to true
-		if (isDataEmpty || isDataLoading) {
+		if (isDataLoading) {
 			this.renderSkeleton(isDataLoading);
 		} else {
 			this.removeSkeleton();