scanpy in requirements?

[giovp]

moscot/requirements.txt

Line 1 in 4b2d1db

anndata>=0.7.6

just had a bug preparing experiments cause scanpy wasn't installed. Thing would be good to add it as requirement since it's probably use a lot, unless strong opinion against.

[giovp]

just noticed that since scanpy is not in req, sklearn also isn't. we def want sklearn to be a dep imho...

[Marius1311]

@michalk8 and @MUCDK, can you take care please?

[michalk8]

@michalk8 and @MUCDK, can you take care please?

Would only add this once we need it (mb. e.g. in #65), not sure what the bug was (I assume it was just a fresh env and scanpy was missing).

[Marius1311]

okay, closing for now until further discussion.

[giovp]

scanpy is still not in requirements and I think we need it so reopening

[Marius1311]

@michalk8, can you give your verdict here please?

[michalk8]

Include when needed, most likely in #96 or when we introduce logging. However scanpy is getting a bit slow to import, so we might roll out own logger. In any case, don't think this warrants an open issue right now, closing this.