-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[development] click CLI + some styling in responses #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looks f'n awesome
required=False, | ||
default="true", | ||
help="Skip `PASSED` rules in jpl report", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@click.option('--verbose', '-v', is_flag=True, help="Print more output.")
I think this is the closest thing to store_true
in argparse
. Might be a bit better than "true"
as a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@click.option('--skip', '-s', is_flag=True, help="Skip
PASSED rules in jpl report.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_flag
will work here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For —verbose
We will want a count so we can increase verbosity
@mitchbregs I made the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome
NEW
-Added a CLI built with
Click
-Moved some logic over to
jpl/cli/main_cli.py
for generatingJiggyPlaybookLint
responseUSAGE
On a file
EDIT
-Made change for
-s
to be -is_flag
-Added further docstrings + type annotating
-Added
README.md