-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rspec 1.3.x support #5
Conversation
I thought it would be nice to support both RSpec 1.x and 2.x in the same gem / branch, but that didn't really work. Your patch is probably one of the nicer ways to handle this, but still makes the whole thing a bit clunky. And, as you said, it's pretty much untestable in one run. I decided to support RSpec 1.x in a separate branch: https://github.com/jeffkreeftmeijer/fuubar/tree/legacy . Thank you so much for your work and sorry for being such a bitch about wanting to support both versions in the same branch. :) |
Is the legacy branch in some gem? |
@elia no, I'm sorry. If you use bundler, you can point right to the git url and get it that way: http://gembundler.com/git.html :) |
@jeffkreeftmeijer yeah I know, if you want I can help I thought about forking and pushing the gem, but I prefer to stay official if possible, |
@elia if you want to create a gem, please go ahead. The reason I never did is because I don't really want to support it anymore. I would accept pull requests for the legacy branch, though. :) |
Fair enough :) Since the legacy branch is a fork of v0.2 I think we can publish it as a 0.2.1 with dep set to rspec ~> 1.0 I know is less than ideal but make sense to me, letting people from both worlds to |
@elia did you ever push a gemified version of this? We could use such a thing at my office. Pointing to the git repo has presented various issues for my colleagues and some servers. |
@sdhull Please support the gem creation in issue #26 @jeffkreeftmeijer any update on the 0.1 gem? |
This issue has been closed automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Rspec 1.3.x support