Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The active menu does not work in mobile. #27

Closed
lunaroyster opened this issue Oct 16, 2015 · 27 comments
Closed

The active menu does not work in mobile. #27

lunaroyster opened this issue Oct 16, 2015 · 27 comments
Assignees

Comments

@lunaroyster
Copy link
Collaborator

No description provided.

@rithvikvibhu
Copy link
Collaborator

Will work on this after studying for a while

@thebongy
Copy link
Contributor

What exactly is not working?

@thebongy
Copy link
Contributor

I think it does work, just that the home link is not activating, everything else is....... well that should be an easy solve.

@rithvikvibhu
Copy link
Collaborator

The #3 doesn't work on mobile

@thebongy
Copy link
Contributor

screenshot_2015-10-16-20-15-33
You mean this? It changes right?

@rithvikvibhu
Copy link
Collaborator

Doesn't work on chrome dev Android and come beta Android. And it seems not only for me

@lunaroyster
Copy link
Collaborator Author

Not on chrome mobile emulator either

@thebongy
Copy link
Contributor

@ritvikvibhu which phone and version of Android are you using?

@thel3l
Copy link
Owner

thel3l commented Oct 17, 2015

@thebongy xD He's using Android 6.0 Dev Preview on a Nexus 4.

@rithvikvibhu
Copy link
Collaborator

:) but also confirmed on 5.0 and 5.1.1

@thel3l
Copy link
Owner

thel3l commented Oct 18, 2015

That's because he will _never_ get a Marshmallow OTA.

@rithvikvibhu
Copy link
Collaborator

@thel3l that is why I have got the PURE AOSP (not cm) before ur opo. ☺

@rithvikvibhu
Copy link
Collaborator

Currently works only when in section 4 and 5. Not for the first 3 sections.

@thebongy
Copy link
Contributor

A possible solution would be to increase the value in the end of line 114 of responsivenav.js to 200. Not entirely sure, did not test, but this could solve the problem....

@thebongy
Copy link
Contributor

I just verified it, changing the value to 250 makes it work with almost all viewport widths

@thebongy
Copy link
Contributor

@rithvikvibhu @thel3l does it work on your phones now? Cause i am not completely sure with the value to be entered there, just estimated. Might need further tinkering.

@rithvikvibhu
Copy link
Collaborator

@thebongy the home, event and FAQ sections all mark the "home" as active. section 4 and 5 work normally

@rithvikvibhu rithvikvibhu reopened this Oct 20, 2015
@thebongy
Copy link
Contributor

@rithvikvibhu is this after applying the fix i posted?

@rithvikvibhu
Copy link
Collaborator

Before the fix, there was no active element when in first 3 sections. Now Home is always active.

@thebongy
Copy link
Contributor

@rithvikvibhu home is active even if viewport is scolled down to section 2,3, or 4?

@rithvikvibhu
Copy link
Collaborator

not 2,3,4. 1,2,3

@thebongy
Copy link
Contributor

@rithvikvibhu you are using a nexus 4 right?

@rithvikvibhu
Copy link
Collaborator

yup

@thebongy
Copy link
Contributor

for now we can ignore the FAQ section right cause it is empty, right?

@thebongy
Copy link
Contributor

or wait sorry misunderstood it. it has stuff...

@thebongy
Copy link
Contributor

@rithvikvibhu this should work, unless its a nexus 4 specific browser issue.

@rithvikvibhu
Copy link
Collaborator

Finally, working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants