Fix incorrect print commands in spreaper #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
requested changes
Jul 18, 2023
| reply = reaper.post("snapshot/cluster/{0}".format(args.cluster_name), | ||
| keyspace=args.keyspace, | ||
| owner=args.owner, cause=args.cause, | ||
| snapshot_name=args.name) | ||
| else: | ||
| if args.node: | ||
| print ("# Taking a snapshot on cluster '{0}' and node '{1}', " | ||
| ).format(args.cluster_name, args.node) | ||
| .format(args.cluster_name, args.node)) | ||
| reply = reaper.post("snapshot/{0}/{1}".format(args.cluster_name, args.node), | ||
| keyspace=args.keyspace, | ||
| owner=args.owner, cause=args.cause, | ||
| snapshot_name=args.name) | ||
| else: | ||
| print ("# Taking a snapshot on cluster '{0}', " |
There was a problem hiding this comment.
This prints
# Taking a snapshot on cluster 'cname',
src/packaging/bin/spreaper
Outdated
| @@ -638,11 +638,11 @@ class ReaperCLI(object): | |||
|
|
|||
| if args.node: | |||
| print ("# Deleting snapshot '{1}' on cluster '{0}' and node '{2}'" | |||
There was a problem hiding this comment.
Please check the ordering of arguments for this one. I think you've reversed cluster name and snapshot name.
src/packaging/bin/spreaper
Outdated
| "targeting tables: {2}").format(args.cluster_name, args.keyspace_name, | ||
| ",".join(args.tables.split(','))) | ||
| "targeting tables: {2}".format(args.cluster_name, args.keyspace_name, | ||
| ",".join(args.tables.split(',')))) |
There was a problem hiding this comment.
Why do you split and then rejoin? Seems redundant.
There was a problem hiding this comment.
The hell if I know 😅 so weird...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1282
The print commands in spreaper's
take-snapshotmethod (and a few others) was not built correctly and had misplaced closing parenthesis.