Restore compatibility with Cassandra 1.2 & 2.0 #631
Conversation
…nce Cassandra 2.1 Restore compatibility with versions prior to 2.1 which doesn't expose this method. On such versions, the default compaction strategy is used (TimeWindowCompactionStrategy & DateTieredCompactionStrategy strategies are not available for those versions).
rborer
force-pushed
the
cassandra-1.2-no-compaction-parameters
branch
from
63a5b15
to
298cbd0
Compare
| * Default compaction strategy, used when the strategy cannot be retrieved from JMX. The | ||
| * information is only available since Cassandra 2.1 | ||
| */ | ||
| private static final String DEFAULT_COMPACTION_STRATEGY = "SizeTieredCompactionStrategy"; |
There was a problem hiding this comment.
@rborer would/does the code break if we make the default value "unknown"? i'm hesitant about presuming a compaction strategy, as we may take an action based on that and it would not be accurate against Cassandra <2.1
There was a problem hiding this comment.
Yeah I've been wondering about putting a default value that doesn't exists here. As far as I can tell the compaction strategy information is only used to skip tables using Time Window / Date Tiered data. So it should be safe to put "unknown" in there instead.
|
This looks good to me. Only the one question about what the filler value for Cassandra 1.2 and 2.0 should be. The integration tests appear to be failing. See https://api.travis-ci.org/v3/job/508315673/log.txt The |
|
@michaelsembwever as far as I understand Travis CI output, the integration tests are failing with versions 1.2 & 2.0. The 400 you are seeing is when it attempts to start an incremental repair which is something introduced in version 2.1 (based on https://www.datastax.com/dev/blog/more-efficient-repairs) as far as I understand it? |
…etrieved since Cassandra 2.1) more explicit.
rborer
force-pushed
the
cassandra-1.2-no-compaction-parameters
branch
from
298cbd0
to
711f941
Compare
…nce Cassandra 2.1 - Restore compatibility with versions prior to 2.1 which doesn't expose this method. - Make unknown compaction strategy (an info that can only be remotely retrieved since Cassandra 2.1) more explicit. ref: #631
…nce Cassandra 2.1 - Restore compatibility with versions prior to 2.1 which doesn't expose this method. - Make unknown compaction strategy (an info that can only be remotely retrieved since Cassandra 2.1) more explicit. ref: #631
|
Merged to both |
|
Thanks again @rborer :-) |
Fixes #629.
As
ColumnFamilyStoreMBean.getCompactionParameters()is only available since Cassandra 2.1, this PR restore compatibility with older versions which doesn't expose this method.On such versions, the default compaction strategy is used (
TimeWindowCompactionStrategy&DateTieredCompactionStrategystrategies are not available for those versions).This PR also configures Travis CI to run integration tests with Cassandra versions 1.2.19 & 2.0.17 (hopefully since I have no clue how to test this).
I've manually deployed this version on my cluster running Cassandra 1.2.19 and so far it's running repairs properly.