Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lounge add user password #353

Closed
morgzz opened this issue May 27, 2016 · 8 comments
Closed

lounge add user password #353

morgzz opened this issue May 27, 2016 · 8 comments
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project. Type: Security Security concern or PRs that must be reviewed with extra care regarding security.

Comments

@morgzz
Copy link

morgzz commented May 27, 2016

Was going to setup a PHP script to execute the add/modify user command(s) but noticed it requires a user to then enter a password securely in the terminal. The documentation look like it allowed a password to be entered in as a parameter but does not currently behave this way.

Examples:
lounge add [user] with no password
would then prompt the user to enter a password

lounge add [user] [password] will not prompt the user to enter a password.

Can this behavior be added into the existing behavior?

@morgzz morgzz changed the title lougne lougne add user password May 27, 2016
@omnicons
Copy link
Contributor

I'm sorry to nag, but can you correct the title's spelling to be correct?

@xPaw
Copy link
Member

xPaw commented May 27, 2016

You can directly edit/create user files if you so desire. The CLI commands just interact with these files. But what you are suggesting is reasonable.

@xPaw xPaw added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. help wanted Tickets the community can help us with, by either answering questions or sending us PRs. labels May 27, 2016
@morgzz morgzz changed the title lougne add user password lounge add user password May 27, 2016
@morgzz
Copy link
Author

morgzz commented May 27, 2016

@omnicons good catch :)

@maxpoulin64
Copy link
Member

I'm not sure how I feel about that. Passing passwords on the command-line is a terrible idea security-wise, as anyone that runs ps aux on the server while the user is being added will see the password right there in clear. If you are going to run the command, I would recommend piping the password in instead. An even better solution would be to just write the JSON as @xPaw said. That way you can customize the other options as well, such as preconfiguring networks and other settings.

Alternatively, this can also be done in the shell itself: echo hunter1 | lounge add test works.

@morgzz
Copy link
Author

morgzz commented May 27, 2016

That's a pretty good point. I'll work on PHP script to write out the JSON. Already looking at the bcyrpt libraries. I'll see what I can come up with.

@morgzz
Copy link
Author

morgzz commented May 28, 2016

Does anyone know if Lounge will freak out if there are extra parameters stored in the json file. Hopefully it ignores them? :-)

Say...
"user": "blah blah",
"email": "someone@gmail.com",
"password": "encrypted",...

@maxpoulin64
Copy link
Member

It will work fine, but it may get erased later when the file is rewritten as it just writes a whitelisted set of properties so I wouldn't count on them staying there.

@astorije astorije added Type: Security Security concern or PRs that must be reviewed with extra care regarding security. and removed help wanted Tickets the community can help us with, by either answering questions or sending us PRs. labels Dec 15, 2016
@astorije
Copy link
Member

astorije commented Dec 15, 2016

I suggest closing this for the security concerns @maxpoulin64 exposed above, which I agree with. Any objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project. Type: Security Security concern or PRs that must be reviewed with extra care regarding security.
Projects
None yet
Development

No branches or pull requests

6 participants