Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make whois a client template #161

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Make whois a client template #161

merged 1 commit into from
Mar 9, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Mar 7, 2016

chrome_2016-03-07_17-10-29

Supercedes #129

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Mar 7, 2016
@astorije
Copy link
Member

astorije commented Mar 8, 2016

Nice @xPaw, it's looking good!
One minor suggestion, could we have channels displayed as is on the following channels: #channel1, #channel2, and #channel3?
It would look even more user-friendly :-)

@astorije astorije self-assigned this Mar 8, 2016
@maxpoulin64
Copy link
Member

I like that, much better looking and better handled. 👍

@xPaw
Copy link
Member Author

xPaw commented Mar 8, 2016

@astorije That's slightly tricky because it uses each loop in the template.

@xPaw xPaw mentioned this pull request Mar 8, 2016
12 tasks
@astorije
Copy link
Member

astorije commented Mar 9, 2016

We could either use tricks to deal with that in the template, but yes, not pretty. A better way would be to define a human-readable list helper (along those lines: http://stackoverflow.com/a/18831911/1935861) but definitely not worth holding off this PR. I'll make an additional PR later for this :-)
👍

astorije added a commit that referenced this pull request Mar 9, 2016
Make whois a client template
@astorije astorije merged commit c8664b7 into thelounge:master Mar 9, 2016
@astorije astorije added this to the 1.4.0 milestone Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants