Improve nick highlights #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
xPaw
force-pushed
the
better-nick-highlights
branch
from
6f64cb0
to
8c8941b
Compare
|
Regexes fixes everything. 👍 |
xPaw
force-pushed
the
better-nick-highlights
branch
from
8c8941b
to
aa8c3f6
Compare
Closed
xPaw
force-pushed
the
better-nick-highlights
branch
2 times, most recently
from
cb2b26b
to
4114c52
Compare
xPaw
force-pushed
the
better-nick-highlights
branch
from
4114c52
to
8a7d1e8
Compare
|
👍 |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Improve nick highlights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159.
Initially tried with some
indexOfand checking characters, but it ends up being messier.