Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache npm modules on appveyor #381

Merged
merged 1 commit into from
Jun 5, 2016
Merged

Cache npm modules on appveyor #381

merged 1 commit into from
Jun 5, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jun 5, 2016

@xPaw xPaw added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. second review needed labels Jun 5, 2016
@xPaw xPaw added this to the 2.0.0 milestone Jun 5, 2016
@astorije astorije self-assigned this Jun 5, 2016
@astorije
Copy link
Member

astorije commented Jun 5, 2016

Considering AppVeyor takes time to start rather than to execute, I don't think this is going to change things a lot, but if their cache invalidation doesn't suck then this comes for free, so it's worth a try.

Also, in general (I saw some bikeshed material on the channel :p), I don't think it's worth investing any time at all on AppVeyor or Windows builds when not super necessary: after all, it's only there to make sure the commands themselves are not broken on Windows. Travis CI is our real source of truth.

👍 and merging! (I restarted a branch build to test something, will delete the branch afterwards)

@astorije astorije merged commit 4f56200 into master Jun 5, 2016
@astorije astorije deleted the xpaw/cache-appveyor branch June 5, 2016 21:53
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants