-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove navigator.standalone detection #427
Conversation
Yeah, infact we should probably remove it because iOS users will be getting 20px less of their screen to see things on. 👍 and merging. |
I think this would have benefited from a bigger timeframe before merging, @YaManicKill, or at least a second review maybe :-) There is still value post-merge if someone stops by though: Is there any iOS user who can post screenshots of before/after this PR? Interested in a post-8.3 for reference (iPhone 6 and higher) and things like iPhone 5 and less, and iPad 2 or 3 (one that is pre-8.3). Thanks! 😄 |
This is how lounge@master looks for me on iOS 9.3.4. |
iPhone 6+ iOS 10 developer beta 7 - Lounge 2.0.0-pre.6 : http://i.imgur.com/zwihk0Z.png |
For the record:
@xPaw, should we revert this? It looks like iOS 9 and 10 still have that issue. |
Further investigations: Air 2 iOS 10 public Beta 6 pre.6 : same bug |
@Thumpxr, @williamboman, any suggestions? What do you think we should do for this? |
Remove navigator.standalone detection
It was added in b3b7d12 to apparently work around an iOS bug which was fixed in 8.3.
https://discussions.apple.com/thread/6557230?start=0&tstart=0
https://discussions.apple.com/message/28059603#28059603