Create a single function to render networks to reduce code duplication #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
Type: Bug
xPaw
force-pushed
the
xpaw/single-network-func
branch
from
53bcf03
to
a09047b
Compare
|
With all the recent changes, I'll rebase this on master and test this before merging. |
|
ooooo, I was sure I had reviewed that one. I'll review as well, although it's liekly fine (it's a different section and really just removes duplicated code) |
astorije
force-pushed
the
xpaw/single-network-func
branch
from
a09047b
to
1fa5451
Compare
|
@maxpoulin64, I just rebased this PR with master, feel free to test it, I'll test when I can find some more time later. |
|
Yeah, 👍 for me. Works fine, and it's a pretty simple change. |
|
Cool, 👍 and merging. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Create a single function to render networks to reduce code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug @maxpoulin64 found: #332 (comment)