Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "The Lounge" label to the landing pages #487

Merged
merged 1 commit into from
Jul 20, 2016
Merged

Conversation

astorije
Copy link
Member

This is a "better" attempt at displaying the app name on the landing page than #424.

This is not an ideal nor permanent solution, but it negatively affects the design less. It is somewhat temporary until I find the time to add a proper landing page that would:

  • Load a sidebar-free page
  • Have a "first-time landing" look (app name + maybe special framing, etc.)
  • Display either a connect page on public mode or a sign in page in private mode

This will take some non-negligible time and I'll have to sync with @maxpoulin64 depending on what he wants to do regarding the window management, so until then, this PR will do the job just fine and does not compromise on the UI.

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Jul 11, 2016
@maxpoulin64
Copy link
Member

Looks fine to me. 👍 I'm not a fan of the empty header still, but that might be fixed with window management.

@astorije
Copy link
Member Author

astorije commented Jul 11, 2016

I'm not a fan of the empty header still, but that might be fixed with window management.

Correct, I have a few ideas you might like, whenever we get to it (later!) :-)

@astorije astorije merged commit 0cc4f0e into master Jul 20, 2016
@astorije astorije deleted the astorije/app-name branch July 20, 2016 03:09
@astorije astorije added this to the 2.0.0 milestone Jul 20, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Add "The Lounge" label to the landing pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants