Make sure git commit check would not send stderr to the console #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that change, running a release would display this in the console: ``` fatal: Not a git repository (or any of the parent directories): .git ``` Also, this adds strict mode for that file, and make sure `gitCommit` never throws a `ReferenceError`.
astorije
added
Type: Bug
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Make sure git commit check would not send stderr to the console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that change, running a release would display this in the console:
Also, this adds strict mode for that file, and make sure
gitCommitnever throws aReferenceError.