Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't read alevin output from salmon 0.14.0 #32

Closed
alexvpickering opened this issue Jun 16, 2019 · 8 comments
Closed

can't read alevin output from salmon 0.14.0 #32

alexvpickering opened this issue Jun 16, 2019 · 8 comments

Comments

@alexvpickering
Copy link

alexvpickering commented Jun 16, 2019

Tried with latest version of tximport installed with devtools::install_github("mikelove/tximport") 1.13.3

tximport::tximport(file.path(alevin_dir, 'quants_mat.gz'), type = 'alevin')

Error in mat[, j] <- readBin(con, double(), endian = "little", n = num.genes) : 
  number of items to replace is not a multiple of replacement length 

Probably related to this:

The binary output format of alevin, quants_mat.gz, has been changed into a sparse single precision format. In pratice we saw the file size reduced to as big as half the size of the original file.

@k3yavi
Copy link

k3yavi commented Jun 16, 2019

Hi @alexvpickering ,

Thanks for the issue.
We are still working on this, in the meantime, I will share a workable version soon.

@mikelove
Copy link
Collaborator

mikelove commented Jun 16, 2019

Thanks for this report. We’ll take a look. @k3yavi and I have a meeting already for tomorrow to discuss the next iteration of the Alevin file format. And we can figure out how tximport needs to change to accommodate Salmon 0.14.

alexvpickering added a commit to hms-dbmi/dseqr that referenced this issue Jun 17, 2019
alexvpickering added a commit to hms-dbmi/dseqr that referenced this issue Jun 17, 2019
@k3yavi
Copy link

k3yavi commented Jun 17, 2019

Hi @alexvpickering ,

Thanks again for raising the issue. As requested by one other user too, we have a shared a basic (non-optimized) R parser for the alevin 0.14.0 output in this COMBINE-lab/salmon#380 thread. We are still working on optimizing the parser and integrating it with tximport and will update you once it is stable.

@mikelove
Copy link
Collaborator

Status update: I'm creating some test data for 0.14 so I can bring in Avi's code into tximport

@mikelove
Copy link
Collaborator

I’ve got a little code but didn’t finish today and want to put in a unit test alongside the new code.

@mikelove
Copy link
Collaborator

Thanks for notifying us quickly to this issue.

Should be fixed by 6f761a7

You can obtain the new code with install_github("mikelove/tximport"). If you can test that it works on your end, i'll push it to release as well.

@mikelove
Copy link
Collaborator

I just pushed 1.12.2 to release branch as well, so it gets circulated tomorrow

@k3yavi
Copy link

k3yavi commented Jun 20, 2019

Thanks @mikelove !

alexvpickering added a commit to hms-dbmi/dseqr that referenced this issue Oct 22, 2019
alexvpickering added a commit to hms-dbmi/dseqr that referenced this issue Jan 12, 2021
need until thelovelab/tximport#32 resolved


Former-commit-id: ac63a4c
Former-commit-id: 1a122a4
Former-commit-id: 16c45e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants