-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an end tag at the end of the post #835
Conversation
Thanks so much for opening your first PR here! |
And the docs about this feature here: https://github.com/theme-next/theme-next.org/blob/source/source/docs/theme-settings/posts.md
|
2. Remove the hard-coded `font-size` in `post-end-tag.swig`. Let it inherit from the parent element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layout/_macro/post-end-tag.swig
This file should be moved to layout/_partials/post/
.
…post/post-end-tag.swig`
Docs updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layout/_macro/post.swig
See by @Raincal comment above firstly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to change
Maybe we must to refactor same feature for add custom fields anywhere. @jiangtj seems suggest something like this. |
@ivan-nginx Like WordPress Widgets? |
#868 Hi, guy. Can you review this, does it meet your needs? My test site: https://jiangtj.gitlab.io/next-test/muse/post/hello-world/ Theme config: custom_file_path:
postBodyEnd: source/_data/post-body-end.swig In <div style="text-align: center; color: #ccc; font-size: 1em;">Thank you for reading</div>
|
@jiangtj Yes, it meets my needs. |
@upcwangying Thanks for your contributing. We will add this feature in #868 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Add an end tag at the end of the post
Issue resolved: N/A
What is the new behavior?
Add an end tag at the end of the post
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?