Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme not fully compatible with VueTorrent rewrite #522

Closed
zerebos opened this issue Nov 17, 2023 · 8 comments
Closed

Theme not fully compatible with VueTorrent rewrite #522

zerebos opened this issue Nov 17, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@zerebos
Copy link

zerebos commented Nov 17, 2023

Describe the bug
Theming partially broken on VueTorrent 2.x.x+. The recently rewrote the entire application in Vue3 and certain aspects of the theme have broken most notably the toolbar and dropdowns.

Theme Install Method (Don't skip)
All methods are affected.

Application Info (Don't skip)

  • Version: 2.x.x+

To Reproduce
Steps to reproduce the behavior:

  1. Update VueTorrent to 2.x.x+
  2. Theme no longer applies to certain parts of the page

Expected behavior
The theme to apply especially to major parts of the page. In the case of the screenshot below, the toolbar should be partially transparent and match the theme colors.

Screenshots
image

Desktop (If applicable) (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (If applicable) (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@zerebos zerebos added the bug Something isn't working label Nov 17, 2023
@QuickSwitchLK
Copy link

I can also confirm this to true. Just updated docker container and have the same issue.

@Codelica
Copy link

Codelica commented Jan 5, 2024

Less noticeable with the "organizr" theme, but the side menu is definitely out of place color-wise. Will need a look sometime. 👍

@syphant
Copy link

syphant commented Feb 21, 2024

Confirming the same with VueTorrent v2.7.0

GilbN added a commit that referenced this issue Feb 25, 2024
@GilbN
Copy link
Collaborator

GilbN commented Feb 25, 2024

See if develop is better.

@Codelica
Copy link

Develop helped the "organizr" theme for me. Only obvious thing I see is the overlay context menus seem to have a transparent background.

qbt-tp

@zerebos
Copy link
Author

zerebos commented Feb 26, 2024

Yes there are some little things not quite right, but it looks much better now!

GilbN added a commit that referenced this issue Mar 3, 2024
@GilbN
Copy link
Collaborator

GilbN commented Mar 3, 2024

Try now.

@Codelica
Copy link

Codelica commented Mar 3, 2024

Thanks, context menus are fixed. 👍

@GilbN GilbN closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants