Forms - Input

[antimprisacaru]

Hi,

I've been working on a concept for forms fields (currently only text/number/etc. inputs, but later can be expanded with others). This is the first draft, with further adjustments coming once I get some feedback. It's inspired by Angular Material, in the sense that it uses content projection to render the elements such as the input, label, hint, etc. without compromising the customizability. For example, attributes such as formControl from Reactive Forms wouldn't have to be supported by flowbite components in order for them to be functional with the native element.

I've thus created a few directives that add flowbite classes to the elements. The targetting in the form field component is done by attribute and element, with prefix and hint only by attribute. As showcased below, elements can be further customized, such as in the case of the label, where I changed the font for only a part of the text. Furthermore, inputs passed onto the form field component are further passed towards the directives, such that there is cohesion. Of course, you can still directly pass inputs to only directives. I haven't played with the edge case where inputs of directives are different from the component's, so I can't vouch for what happens then. I'm thinking there could be a mechanism to ensure only unidirectional flow, if the directive is used within the form field (i.e., perhaps leaving current inputs but also adding a properties input and prioritizing the properties over the direct inputs).

Besides that, I've also added an utility mechanism that autogenerates an ID to the input, such that the label can be linked to it. This can be further expanded to generate an ID for the rest of the elements and I could refactor the code to allow the user to give a custom ID to each element. I've also assumed that hint is the same as helper text. Perhaps there could also be a distinction between error and hint. Then, prefix is yet to be implemented, as of right now I'm thinking that there could be a svg for the icon and a span for the addon. I'll also refactor the demo page such that it better reflects the original flowbite documentation, currently it's only a testing showcase of how it works currently.

As a final note, I placed all form field related components/directives into one module, since they're quite strongly linked between each other.

Looking forward to hearing an opinion!

Edit: Wrapped up with the implementation and refactored examples. I think this is a good starting point.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-angular	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 27, 2023 1:52pm

[boskiv]

lgtm

[MGREMY]

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[coderabbitai]

Warning

Rate limit exceeded

@MGREMY has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7445202 and 3af46c0.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.