Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lib component template #30

Merged
merged 12 commits into from
Jan 16, 2024
Merged

Conversation

MGREMY
Copy link
Collaborator

@MGREMY MGREMY commented Jan 16, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a new modal component with enhanced accessibility and dynamic content projection.
    • Added a navigation component with responsive styling and content insertion capabilities.
    • Implemented a sidebar component that adjusts its width based on user interactions and includes dynamic content.
    • Added a dropdown component with toggle functionality and customizable content.
    • Introduced a button component for toggling dark and light themes, complete with visual indicators.
    • Enhanced form field component with support for floating labels and various input types.
  • Improvements

    • Transitioned multiple components from inline templates to external HTML files for better maintainability and readability.
  • Bug Fixes

    • Resolved various layout and styling issues across components to improve user experience.

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-angular ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 8:54pm

@MGREMY MGREMY merged commit 68c80f9 into main Jan 16, 2024
3 checks passed
@MGREMY MGREMY deleted the refactor-lib-component-template branch January 16, 2024 21:01
@MGREMY
Copy link
Collaborator Author

MGREMY commented Nov 4, 2024

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

coderabbitai bot commented Nov 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant changes to the Flowbite Angular library, primarily focusing on restructuring various components by moving inline templates to external HTML files. This includes components such as accordions, alerts, buttons, modals, and sidebars. Additionally, new HTML structures are added to enhance the layout and functionality of these components, allowing for better content projection and dynamic styling based on component properties.

Changes

File Path Change Summary
libs/flowbite-angular/src/lib/components/accordion/accordion-content.component.html Added a <div> that conditionally renders based on accordionPanel.open, containing <ng-content>.
libs/flowbite-angular/src/lib/components/accordion/accordion-content.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/accordion/accordion-panel.component.html Added <div> with <ng-content> for content projection.
libs/flowbite-angular/src/lib/components/accordion/accordion-panel.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/accordion/accordion-title.component.html Introduced a button with dynamic styling and click event to toggle accordion state.
libs/flowbite-angular/src/lib/components/accordion/accordion-title.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/accordion/accordion.component.html Added a styled <div> with <ng-content> for content projection.
libs/flowbite-angular/src/lib/components/accordion/accordion.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/alert/alert.component.html New structured alert component with dynamic classes and dismiss button.
libs/flowbite-angular/src/lib/components/alert/alert.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/badge/badge.component.html Introduced a <span> with dynamic classes and anchor element for navigation.
libs/flowbite-angular/src/lib/components/badge/badge.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/breadcrumb/breadcrumb-item.component.html Added new SVG icon and anchor element with conditional rendering.
libs/flowbite-angular/src/lib/components/breadcrumb/breadcrumb-item.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/breadcrumb/breadcrumb.component.html Introduced a <nav> element for accessibility and content projection.
libs/flowbite-angular/src/lib/components/breadcrumb/breadcrumb.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/button/button.component.html New button component with dynamic classes and content projection.
libs/flowbite-angular/src/lib/components/button/button.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/dark-theme-toggle/dark-theme-toggle.component.html Introduced a button to toggle dark/light themes with conditional SVG icons.
libs/flowbite-angular/src/lib/components/dark-theme-toggle/dark-theme-toggle.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/dropdown/dropdown-divider.component.html Added a styled <li> for visual separation in dropdowns.
libs/flowbite-angular/src/lib/components/dropdown/dropdown-divider.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/dropdown/dropdown-header.component.html New structure with content projection and visual separator.
libs/flowbite-angular/src/lib/components/dropdown/dropdown-header.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/dropdown/dropdown-item.component.html New <li> with dynamic styling and content projection.
libs/flowbite-angular/src/lib/components/dropdown/dropdown-item.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/dropdown/dropdown.component.html New dropdown component with toggle functionality and content projection.
libs/flowbite-angular/src/lib/components/dropdown/dropdown.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/form-field/form-field.component.html Enhanced structure for floating labels and input types with various templates.
libs/flowbite-angular/src/lib/components/form-field/form-field.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/indicators/indicators.component.html Added a <div> with dynamic class bindings for styling.
libs/flowbite-angular/src/lib/components/indicators/indicators.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/modal/modal-body.component.html Added a <div> for content projection in modal body.
libs/flowbite-angular/src/lib/components/modal/modal-body.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/modal/modal-footer.component.html New structure for modal footer with content projection.
libs/flowbite-angular/src/lib/components/modal/modal-footer.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/modal/modal-header.component.html New modal header with title and close button.
libs/flowbite-angular/src/lib/components/modal/modal-header.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/modal/modal.component.html New modal component structure with dynamic visibility and content projection.
libs/flowbite-angular/src/lib/components/modal/modal.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/navbar/navbar.component.html New navigation component with responsive design and content projection.
libs/flowbite-angular/src/lib/components/navbar/navbar.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/sidebar/sidebar-item-group.component.html New structure for sidebar item group with content projection.
libs/flowbite-angular/src/lib/components/sidebar/sidebar-item-group.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/sidebar/sidebar-item.component.html New structure for sidebar item with navigation and icon display.
libs/flowbite-angular/src/lib/components/sidebar/sidebar-item.component.ts Changed from inline template to external HTML file.
libs/flowbite-angular/src/lib/components/sidebar/sidebar.component.html New sidebar component with dynamic width based on state.
libs/flowbite-angular/src/lib/components/sidebar/sidebar.component.ts Changed from inline template to external HTML file.

Possibly related PRs

  • fix(modal): close on route change #33 #56: The changes in the ModalComponent related to its template structure and lifecycle management are relevant as they involve modifications to how the modal's content is rendered and managed, which may relate to the overall structure and functionality of components like accordion-content.component.html that also deal with dynamic content rendering.

🐰 In the garden of code, we hop with glee,
New templates bloom, as bright as can be!
With buttons and modals, all fresh and new,
Our components dance, in a colorful view.
Content flows freely, like a gentle stream,
In the world of Angular, we craft and we dream! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant