Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox: add 'indeterminate' prop #871

Open
2 tasks done
tulup-conner opened this issue Jul 20, 2023 Discussed in #870 · 6 comments
Open
2 tasks done

Checkbox: add 'indeterminate' prop #871

tulup-conner opened this issue Jul 20, 2023 Discussed in #870 · 6 comments
Assignees
@grasdira
Labels
good first issue Good for newcomers 🚀 enhancement New feature or request
Milestone
1.0.0

Comments

@tulup-conner
Copy link
Collaborator

tulup-conner commented Jul 20, 2023 •
edited
Loading

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Summary

Discussed in #870

Originally posted by grasdira July 19, 2023

Enhancement Suggestion

I think it would be nice to add indeterminate (or isIndeterminate) prop to Checkbox component.

Example:

<Checkbox indeterminate .. />

Context

This is officially supported by DOM elements in all browsers. See https://developer.mozilla.org/en-US/docs/Web/CSS/:indeterminate
@tulup-conner tulup-conner added 🚀 enhancement New feature or request good first issue Good for newcomers labels Jul 20, 2023
@tulup-conner tulup-conner added this to the 1.0.0 milestone Jul 20, 2023
@grasdira
Copy link

Hi! I'd like to take a shot at solving this issue. Could you assign it to me? Thanks

@tulup-conner
Copy link
Collaborator Author

@grasdira Done, but for the future, you are always welcome to just get started on an issue!

@shereen-fathy
Copy link

Hi @grasdira, any progress on this issue?

@grasdira
Copy link

Hi @shereen-fathy, yes, I've made some progress on this issue.

grasdira added a commit to grasdira/flowbite-react that referenced this issue Nov 28, 2023
@grasdira
feat(checkbox): add indeterminate state to checkbox component
8abc82d 
themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Nov 28, 2023
@grasdira
feat(storybook style.css and docs.css): override the original style o…
65e9f8b 
…f checkbox :indeterminate

Override the original style of [type='checkbox']:indeterminate.

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Nov 28, 2023
@grasdira
docs(forms.checkbox.tsx): add indeterminate checkbox example to docs
eaafa1c 
themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Nov 28, 2023
@grasdira
docs(new:forms.checkboxindeterminate.tsx): add a separated example fo…
f1a8478 
…r indeterminate checkbox

Add an example of using the indeterminate state to handle multiple checkboxes in a group of tree
structure.

themesberg#871
@grasdira grasdira mentioned this issue Nov 28, 2023
Open
1 task
tulup-conner pushed a commit to grasdira/flowbite-react that referenced this issue Nov 30, 2023
@grasdira @tulup-conner
feat(checkbox): add indeterminate state to checkbox component
efb0707 
themesberg#871
tulup-conner pushed a commit to grasdira/flowbite-react that referenced this issue Nov 30, 2023
@grasdira @tulup-conner
feat(storybook style.css and docs.css): override the original style o…
71e11af 
…f checkbox :indeterminate

Override the original style of [type='checkbox']:indeterminate.

themesberg#871
tulup-conner pushed a commit to grasdira/flowbite-react that referenced this issue Nov 30, 2023
@grasdira @tulup-conner
docs(forms.checkbox.tsx): add indeterminate checkbox example to docs
23df367 
themesberg#871
tulup-conner pushed a commit to grasdira/flowbite-react that referenced this issue Nov 30, 2023
@grasdira @tulup-conner
docs(new:forms.checkboxindeterminate.tsx): add a separated example fo…
22e6f68 
…r indeterminate checkbox

Add an example of using the indeterminate state to handle multiple checkboxes in a group of tree
structure.

themesberg#871
@Stupidism
Copy link

Any progress on this issue? Thanks~~

grasdira added a commit to grasdira/flowbite-react that referenced this issue Jan 17, 2024
@grasdira
style(tailwind.config.ts): added extended theme for tailwind
a4af18f 
Added extended theme 'colors.current' and 'backgroundImage.indeterminate' to set default styles for
indeterminate checkbox

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Jan 17, 2024
@grasdira
style(style.css, docs.css): remove [type='checkbox']:indeterminate st…
90ec304 
…yles

remove [type='checkbox']:indeterminate styles to make development more flexibility

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Jan 17, 2024
@grasdira
style(component:checkbox.tsx): added default tailwindCSS classes for …
a1bfc21 
…the indeterminate state

'indeterminate:bg-indeterminate' uses the extended backgroundImage in `tailwind.config.ts`;
'dark:indeterminate:bg-current dark:indeterminate:border-gray-600' fixes checkbox's bg-color and
border under dark mode

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 3, 2024
@grasdira
feat(checkbox): add indeterminate state to checkbox component
6ec82f3 
themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 3, 2024
@grasdira
feat(storybook style.css and docs.css): override the original style o…
d9662bd 
…f checkbox :indeterminate

Override the original style of [type='checkbox']:indeterminate.

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 3, 2024
@grasdira
docs(forms.checkbox.tsx): add indeterminate checkbox example to docs
2b06acf 
themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 3, 2024
@grasdira
docs(new:forms.checkboxindeterminate.tsx): add a separated example fo…
5564a3c 
…r indeterminate checkbox

Add an example of using the indeterminate state to handle multiple checkboxes in a group of tree
structure.

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 3, 2024
@grasdira
style(tailwind.config.ts): added extended theme for tailwind
9a4f930 
Added extended theme 'colors.current' and 'backgroundImage.indeterminate' to set default styles for
indeterminate checkbox

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 3, 2024
@grasdira
style(style.css, docs.css): remove [type='checkbox']:indeterminate st…
f6a6ea2 
…yles

remove [type='checkbox']:indeterminate styles to make development more flexibility

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 3, 2024
@grasdira
style(component:checkbox.tsx): added default tailwindCSS classes for …
1943cc3 
…the indeterminate state

'indeterminate:bg-indeterminate' uses the extended backgroundImage in `tailwind.config.ts`;
'dark:indeterminate:bg-current dark:indeterminate:border-gray-600' fixes checkbox's bg-color and
border under dark mode

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 4, 2024
@grasdira
chore(package.json): upgrade flowbite to latest version
753f342 
The indeterminate icon fixed in a recent commit:
themesberg/flowbite@ec0eab5 Upgrade
flowbite version to apply changes.

themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 4, 2024
@grasdira
style: remove extended theme: bg-indeterminate
e1c37ae 
themesberg#871
grasdira added a commit to grasdira/flowbite-react that referenced this issue Mar 4, 2024
@grasdira
style(tailwind.config): remove extended color: current
1586050 
themesberg#871
@coderabbitai coderabbitai bot mentioned this issue Apr 8, 2024
Merged
7 tasks
@azerazerty
Copy link

is this fixed or not yet ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grasdira grasdira

Labels
good first issue Good for newcomers 🚀 enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
5 participants
@Stupidism @azerazerty @grasdira @shereen-fathy @tulup-conner