Add tests, basic DB seeding, and email package #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2015 15:17
…d DB). Added xolvio:cucumber, xolvio:email-stub, and email package along with passing tests for user signup, user login, and recover password.
…ison of Meteor, 1.2.0.1
|
Cool, thanks for putting this together :) Will review this week and add notes. |
|
No sweat. I'm sure I wouldn't have nailed it perfectly the first time :) |
|
Hey @DevanB, I'm going to close out this PR for now, but let's chat in Slack on how we can bring it into the latest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This biggest part of this PR adds tests for user accounts (Tests - #44) based scenarios including the default user signup, user login, and user recover password functionality in Base.
In order to achieve this
xolvio:cucumber,xolvio:email-stub, andmeteor add emailwere added. In addition a new packagethemeteorchef:test-fixtureswas created and added as a local package.themeteorchef:test-fixturesadds a simplefixtures/resetandfixtures/seedDataDB functionality.Other issues this will touch are "Add email package and examples" (#66) by adding the email package and "Seeding" (#56) by adding a custom
fixtures/seedDataDB function (only adds one user for testing), but does not use Faker. I think I can integrate Faker here if you would like that before releasing this into the wild.It might be something to think about allowing these tests to be added as a package in the future, so users can choose to have some basic tests or not. Also, this is not using any fancy ES2015 features. I tried to use arrow functions, but cucumber didn't like them. Perhaps the syntax was incorrect, who knows.
Enjoy :)
Feel free to give me a shout on TMC Slack if you have any questions, comments, complains, or praises!