Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use switches for checkboxes #21

Closed
aristath opened this issue Sep 6, 2014 · 3 comments
Closed

use switches for checkboxes #21

aristath opened this issue Sep 6, 2014 · 3 comments
Labels
Milestone

Comments

@aristath
Copy link
Contributor

aristath commented Sep 6, 2014

See http://codepen.io/ZoFish/pen/CLxmq for an implementation

@richardtape
Copy link

I absolutely love this framework. Thank you so much for your hard work.

imho use switches like this is problematic for at least 2 main reasons:

  1. It's not "The WordPress way" - I think frameworks such as this should stick to the way WordPress handles options as much as possible. It makes for a more consistent user experience across the platforms
  2. There's no solid research on how good or bad switches are for accessibility or general UX. However there is a metric crap-tonne for a standard checkbox.

My personal preference here would be to stick to checkboxes. However, if you wanted to go with switches, I would go with a solution which would allow me as a developer to use them or not'

'use_switches' => true

As part of the settings array, for example.

My 2 cents. Again, thanks for your hard work on this.

@aristath
Copy link
Contributor Author

hey there!
I'm glad you like Kirki. 😄

IF we finally implement switwes, of course there's going to be an argument that will allow you to enable them on a per-setting basis.
For consistency we'll probably use 'mode' => 'switch' since we use 'mode' on radios as well.

@aristath aristath modified the milestone: 0.6 Feb 16, 2015
@aristath
Copy link
Contributor Author

2 new modes have been added: switch and toggle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants